Feature flags #1715
Merged
Feature flags #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 22, 2019
1715: Feature flags r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
This was referenced Aug 22, 2019
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 22, 2019
1715: Feature flags r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 22, 2019
1715: Feature flags r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 22, 2019
1715: Feature flags r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
Build succeeded |
|
Should we be using |
|
Quite likely! I haven't yet fully understood how configuration is supposed to work with LSP, so I just pile additional stuff onto the thing we have |
jens1o
reviewed
Aug 22, 2019
| @@ -587,17 +602,20 @@ fn update_file_notifications_on_threadpool( | |||
| subscriptions: Vec<FileId>, | |||
| ) { | |||
| log::trace!("updating notifications for {:?}", subscriptions); | |||
| let publish_diagnostics = world.feature_flags().get("lsp.diagnostics"); | |||
| pool.execute(move || { | |||
There was a problem hiding this comment.
Couldn't you do a pre-spawn condition check whether this will actually do something? This is in the main thread and loop, and maybe we don't even do something, yet we spawn a useless thread (iterating over files for nothing)?
There was a problem hiding this comment.
This doesn’t spawn a thread, just sends a closure over a channel, it”s only a constant amount of work, comparable to the work we need to get to this point in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.