internal: Remove lens.forceCustomCommands config #17675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
PaulDotSH
force-pushed
the
remove-lens-force-custom-commands-config
branch
2 times, most recently
from
3c53f11 to
45608bb
Compare
nemethf
reviewed
Jul 22, 2024
lnicola
approved these changes
Jul 23, 2024
Member
|
Thanks! @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Jul 23, 2024
…nfig, r=lnicola Remove lens.forceCustomCommands config Closes #17643 A very simple PR that removes the lens.forceCustomCommands config feature without side effects.
Member
|
@bors r- |
Contributor
|
☀️ Try build successful - checks-actions |
lnicola
reviewed
Jul 23, 2024
crates/rust-analyzer/src/config.rs
Outdated
| pub fn client_commands(&self) -> ClientCommandsConfig { | ||
| let commands = self.commands(); | ||
| let force = commands.is_none() && *self.lens_forceCustomCommands(); | ||
| let force = commands.is_none(); |
Member
There was a problem hiding this comment.
It's unrelated to this PR and not a big deal, but I think we call client_commands four times per hover action, and it does a bunch of allocations, so we might want to cache it.
PaulDotSH
force-pushed
the
remove-lens-force-custom-commands-config
branch
from
45608bb to
49184a1
Compare
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17643
A very simple PR that removes the lens.forceCustomCommands config feature without side effects.