Skip to content

fix: Set RUSTUP_TOOLCHAIN when loading sysroot workspace #19159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 16, 2025

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2025
@Veykril Veykril enabled auto-merge February 16, 2025 09:54
@Veykril Veykril added this pull request to the merge queue Feb 16, 2025
Merged via the queue into rust-lang:master with commit fb8bc31 Feb 16, 2025
9 checks passed
@Veykril Veykril deleted the push-kwtzytsyktpv branch February 16, 2025 10:24
@weihanglo
Copy link
Member

This was mentioned in rust-lang/rust#136779 (comment), though I had a hard time figuring out what the bug this tried to fix here is? Would you mind sharing a bit more on this?

@Veykril
Copy link
Member Author

Veykril commented Apr 18, 2025

I believe the issue here is that we run cargo metadata on the sysroot library source but prior to this PR we did not set the RUSTUP_TOOLCHAIN env var for that invocation, and as such, if the cargo we invoke here is the rustup proxy then that might pick a different toolchain cargo than the one we want to use for current workspace being analyzed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants