fix: Make #[target_feature] always safe on WASM
#20642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make it easier to expand it more in the future, if needed.
Even when the feature isn't enabled, as it's not UB to invoke an undefined feature in WASM (just a trap).
rustbot
added
the
S-waiting-on-review
| @@ -194,6 +197,12 @@ impl FixtureWithProjectMeta { | |||
| fixture = remain; | |||
| } | |||
|
|
|||
| if let Some(meta) = fixture.strip_prefix("//- target_arch:") { | |||
There was a problem hiding this comment.
I think one day we might need a dev guide docs for those test attributes. Though this one is quite straightforward but some of which introduced by me are subtle 😅
ShoyuVanilla
approved these changes
Sep 11, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when the feature isn't enabled, as it's not UB to invoke an undefined feature in WASM (just a trap).
Fixes #20640.