Skip to content

Delete support for rustc_intrinsic_must_be_overridden #20663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Delete support for rustc_intrinsic_must_be_overridden #20663

wants to merge 1 commit into from
+4 −54

Conversation

cammeresi
Copy link

@cammeresi cammeresi commented Sep 13, 2025 •
edited by rustbot
Loading

Also extern "rust-intrinsic".

Closes #19539

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2025
@rustbot

This comment has been minimized.

Sign in to view
@ChayimFriedman2
Copy link
Contributor

ChayimFriedman2 commented Sep 14, 2025 •
edited
Loading

They were removed only three versions ago; I'm not sure we should remove them yet. What will be the effect of the removal on coding with pre-1.87 version?

@cammeresi
Copy link
Author

The issue said "will land with 1.87" and rust-analyzer has rust-version = "1.88", which I assumed was a support cutoff. Have I misunderstood?

@ChayimFriedman2
Copy link
Contributor

The rust-version is for what version we support compiling r-a with. This will affect the version we support to analyze.

@cammeresi
Copy link
Author

Okay, thanks for the info. Out of curiosity, how far back does support extend?

@ChayimFriedman2
Copy link
Contributor

I don't know. That depends on the maintenance burden and the impact on users. @Veykril what do you think in this case?

@Veykril
Copy link
Member

Veykril commented Sep 15, 2025

The actual supported version is defined her ehttps://github.com/rust-lang/rust-analyzer/blob/622b2675db4ff353d91b54b450bc0574bdab824c/crates/rust-analyzer/src/lib.rs#L13-L19

I don't think we should bump it just for this small code for now

@cammeresi cammeresi closed this Sep 15, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"rust-intrinsic" ABI and #[rustc_intrinsic_must_be_overridden] support has been removed from the compiler
4 participants
@cammeresi @rustbot @ChayimFriedman2 @Veykril