Skip to content

Use rustup toolchain install instead of rustup install #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2019

Conversation

edwin0cheng
Copy link
Member

@edwin0cheng edwin0cheng commented Dec 8, 2019

rustup install and rustup uninstall are going to be deprecated in rustup 1.21.0

See rust-lang/rustup#2148

and https://www.reddit.com/r/rust/comments/e7rer9/we_need_your_help_before_rustup_1210_can_be/

@matklad
Copy link
Member

matklad commented Dec 8, 2019

Yeah, I am pretty sure they would revert the deprecation, but let's merge this nontheless

bors r+

bors bot added a commit that referenced this pull request Dec 8, 2019
2504: Use rustup toolchain install instead of rustup install r=matklad a=edwin0cheng

`rustup install` and `rustup uninstall` are going to be deprecated in rustup 1.21.0

See rust-lang/rustup#2148

and https://www.reddit.com/r/rust/comments/e7rer9/we_need_your_help_before_rustup_1210_can_be/



Co-authored-by: Edwin Cheng <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 8, 2019

Build succeeded

  • Rust
  • TypeScript

@bors bors bot merged commit 74c7c7a into rust-lang:master Dec 8, 2019
@edwin0cheng edwin0cheng deleted the fix-rustup-install branch December 8, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants