Assist: replace string with char #6256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <[email protected]>
Veykril
reviewed
Oct 16, 2020
bnjjj
force-pushed
the
feat_assist_string_char
branch
from
4aa8609 to
d143bf2
Compare
Signed-off-by: Benjamin Coenen <[email protected]>
bnjjj
force-pushed
the
feat_assist_string_char
branch
from
d143bf2 to
c22c039
Compare
matklad
reviewed
Oct 20, 2020
| let value = token.value()?; | ||
| let target = token.syntax().text_range(); | ||
|
|
||
| if value.is_empty() || value.chars().count() > 1 { |
Contributor
There was a problem hiding this comment.
Suggested change
| if value.is_empty() || value.chars().count() > 1 { | |
| if value.chars().count() != 1 { |
but its probably best to avoid premature pessimization and call .next twice manually instead of O(N) count
other then this, lgmt!
bors d+
Contributor
|
✌️ bnjjj can now approve this pull request. To approve and merge a pull request, simply reply with |
matklad
reviewed
Oct 20, 2020
Co-authored-by: Aleksey Kladov <[email protected]>
Contributor
Author
|
bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6252