Skip to content

Fix --newtype-global-enum option #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix --newtype-global-enum option #2271

merged 1 commit into from
Sep 19, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 12, 2022

Apparently #2270 introduced several bugs:

  • The RegexSet for --newtype-global-enum was not initialized correctly.
  • The flag was not emitted when the option was used either.
  • The generated bindings did not use a newtype.

All three have been fixed here.

@pvdrz pvdrz requested review from emilio and kulp and removed request for emilio September 12, 2022 18:49
@pvdrz pvdrz mentioned this pull request Sep 12, 2022
Closed
@pvdrz pvdrz force-pushed the fix-newtype-global-enum branch from 47a3a6e to 0ffe307 Compare September 12, 2022 18:50
@kulp
Copy link
Member

kulp commented Sep 14, 2022

Apparently #2270 introduced several bugs:

Well, that shows how much I did not know!

I will take a look at this again soon when I am more alert, unless @emilio gets to it first. Thanks for addressing these issues.

kulp
kulp approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@kulp kulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Thanks again!

@kulp kulp merged commit 0d805d7 into rust-lang:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulp kulp kulp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvdrz @kulp