This repository was archived by the owner on Nov 26, 2020. It is now read-only.
Cargo update; and support converting *.xz to *.gz when promoting a release.#31
Merged
Conversation
This is the first step to stop uploading *.gz into the internal S3 bucket.
Member
|
Thanks! It is actually sort of nice that the release takes ~40m right now, most of that being network time. We have such a huge amount of artifacts though I'd imagine that this could take quite awhile... The machine we do releases on I think is also a pretty small instance :( That being said I'm fine having this as a backstop? I think I'd prefer that we don't turn off gz tarball generation just yet, but perhaps we could land this and have that in our back pocket for emergencies? How's that sound? |
Member
Author
Yeah sure, we could proceed whenever comfortable 🙂 |
Member
|
Ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to rust-lang/rust#45002.
The first commit ab4c52f just updates all dependencies to their latest version, and also eliminated the
rustc-serializedependency fromrbars.The second commit 99de474 adds the capability of creating a
*.gzfrom a*.xzwhen the former is missing. This allows us to skip creating*.gzfrom the Rust CI, and thus save ~50% in S3 and AppVeyor space usage. The trade-off is release generation will take longer (recompression takes ~1 MB/s on my laptop).