needless_pass_by_ref_mut false positive in nested async

[hatoo]

Summary

needless_pass_by_ref_mut false positive

I think it's another variant of #11179, sorry if this issue is a duplicate.

Lint Name

needless_pass_by_ref_mut

Reproducer

I tried this code:

async fn f(x: &mut i32) {
    async {
        *x += 1;
    }
    .await;
}

I saw this happen:

❯ cargo +nightly clippy 
warning: this argument is a mutable reference, but not used mutably
 --> src/main.rs:8:15
  |
8 | async fn f(x: &mut i32) {
  |               ^^^^^^^^ help: consider changing to: `&i32`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
  = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default

I expected to see this happen:

No warning

Version

rustc 1.73.0-nightly (eb088b8b9 2023-08-05)
binary: rustc
commit-hash: eb088b8b9d98f1af1b0e61bbdcd8686e1b0db7b6
commit-date: 2023-08-05
host: x86_64-unknown-linux-gnu
release: 1.73.0-nightly
LLVM version: 16.0.5

Additional Labels

No response

[Centri3]

cc @GuillaumeGomez

Doesn't look like the same issue.

[GuillaumeGomez]

I see the problem: need recursion for closures. Gonna check tomorrow.

[GuillaumeGomez]

I opened #11314 to fix this issue.

[MingweiSamuel]

Following example is also a false positive: (and looks about the same?)
https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=2f930223459b2cb29f6c9e4a06a87546

pub async fn foo(n: &mut usize) -> impl '_ + FnMut() {
    || {
        *n += 1;
    }
}

@GuillaumeGomez could you add [something like] this to the test cases in #11314 ?

Edit: #11380

[SpeckyYT]

I'm also experiencing this same false positive.

warning: this argument is a mutable reference, but not used mutably
 --> src\input.rs:8:19
  |
8 |     inputs_queue: &mut VecDeque<Inputs<bool>>,
  |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&VecDeque<Inputs<bool>>`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
  = note: `#[warn(clippy::needless_pass_by_ref_mut)]` on by default

despite doing inputs_queue.append(&mut inputs_vector) in code.
I also using async/await.

[GuillaumeGomez]

@MingweiSamuel Thanks! I'll add it.

@SpeckyYT Would have been better to come up with a small example showing the issue. ^^'

[GuillaumeGomez]

@MingweiSamuel Just took a look and your case is a different one. Do you mind opening a new issue and tagging me on it please?

[SpeckyYT]

Sorry for not providing an example.
Here is a simplified version of what my code is doing (the original code contains .awaits and other stuff, but they seem to not affect this bug).

async fn a(b: &mut Vec<bool>) {
    b.append(&mut vec![])
}

warning: this argument is a mutable reference, but not used mutably
 --> src\test.rs:1:15
  |
1 | async fn a(b: &mut Vec<bool>) {
  |               ^^^^^^^^^^^^^^ help: consider changing to: `&Vec<bool>`
  |

[GuillaumeGomez]

Thanks! I don't know if #11314 is the one who fixed it but in my case I don't have any warning with your code. I tested with push as well just in case. I'll add your code as a regression test in the PR.

[MingweiSamuel]

@GuillaumeGomez

@MingweiSamuel Just took a look and your case is a different one. Do you mind opening a new issue and tagging me on it please?

Looks like someone opened #11380 for this