`new_ret_no_self` false positive when returning `impl Trait<Self>` #7344

nbdd0121 · 2021-06-11T03:00:16Z

Lint name: new_ret_no_self

pub struct Foo;

impl Foo {
    pub fn new() -> impl Into<Self> {
        Foo
    }
}

causes a warning where it shouldn't. impl Into here can be any trait that has Self in generic arguments.

This is similar to #4359 but instead of Future<Output = Self> it's Into<Self>. #4365's title implies that this should be allowed but actually it only deals with associated types, not type parameters.

cargo clippy -V: 0.1.54 (2021-06-09 eab201d)

The text was updated successfully, but these errors were encountered:

nbdd0121 · 2022-10-27T08:52:07Z

@rustbot claim

The clippy false positive triggering `new_ret_no_self` lint when using `pin_init!` macro is fixed in 1.67, so remove all `#[allow]`s ignoring the lint. Signed-off-by: Gary Guo <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Martin Rodriguez Reboredo <[email protected]> Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Reviewed-by: Finn Behrens <[email protected]> Link: https://lore.kernel.org/r/[email protected]

Since Rust 1.67.0, Clippy's `new_ret_no_self` lint learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel is nowadays on Rust 1.71.1, thus remove the `allow`. Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Signed-off-by: Gary Guo <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Martin Rodriguez Reboredo <[email protected]> Reviewed-by: Finn Behrens <[email protected]> Link: https://lore.kernel.org/r/[email protected] [boqun: Applied Miguel's rewording]

Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Signed-off-by: Gary Guo <[email protected]> Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Reviewed-by: Finn Behrens <[email protected]> Reviewed-by: Martin Rodriguez Reboredo <[email protected]> Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Link: https://lore.kernel.org/r/[email protected] [ Reworded slightly and added a couple `Link`s. ] Signed-off-by: Miguel Ojeda <[email protected]>

Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Signed-off-by: Gary Guo <[email protected]> Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Benno Lossin <[email protected]> Reviewed-by: Finn Behrens <[email protected]> Reviewed-by: Martin Rodriguez Reboredo <[email protected]> Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Link: https://lore.kernel.org/r/[email protected] [ Reworded slightly and added a couple `Link`s. ] Signed-off-by: Miguel Ojeda <[email protected]> [ Upstream commit b2516f7 ] Change-Id: I94d65058fd3ed92d9a5582e7163cfc627afe5ed3 Signed-off-by: Alice Ryhl <[email protected]>

Perform the same clean commit b2516f7 ("rust: kernel: remove `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in workqueue in parallel in commit 7324b88 ("rust: workqueue: add helper for defining work_struct fields"): Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Signed-off-by: Miguel Ojeda <[email protected]>

Perform the same clean commit b2516f7 ("rust: kernel: remove `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in workqueue in parallel in commit 7324b88 ("rust: workqueue: add helper for defining work_struct fields"): Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Tested-by: Gary Guo <[email protected]> Reviewed-by: Gary Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>

commit 024f967 upstream. Perform the same clean commit b2516f7 ("rust: kernel: remove `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in workqueue in parallel in commit 7324b88 ("rust: workqueue: add helper for defining work_struct fields"): Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Tested-by: Gary Guo <[email protected]> Reviewed-by: Gary Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>

commit 024f967 upstream. Perform the same clean commit b2516f7 ("rust: kernel: remove `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in workqueue in parallel in commit 7324b88 ("rust: workqueue: add helper for defining work_struct fields"): Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Tested-by: Gary Guo <[email protected]> Reviewed-by: Gary Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>

commit 024f967 upstream. Perform the same clean commit b2516f7 ("rust: kernel: remove `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in workqueue in parallel in commit 7324b88 ("rust: workqueue: add helper for defining work_struct fields"): Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Tested-by: Gary Guo <[email protected]> Reviewed-by: Gary Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> (cherry picked from commit a3d5dcc9ec48e63c0759879178d27b7a5837e176) Signed-off-by: Jack Vogel <[email protected]>

nbdd0121 added C-bug Category: Clippy is not doing the correct thing I-false-positive Issue: The lint was triggered on code it shouldn't have labels Jun 11, 2021

nbdd0121 mentioned this issue Oct 26, 2022

rust: add new api for initialization Rust-for-Linux/linux#909

Closed

rustbot assigned nbdd0121 Oct 27, 2022

nbdd0121 mentioned this issue Oct 27, 2022

Ensure new_ret_no_self is not fired if impl Trait<Self> is returned. #9733

Merged

bors closed this as completed in 33137dd Oct 28, 2022

nbdd0121 mentioned this issue Dec 15, 2022

Fix error caused by recursion into Self. #10068

Closed

ojeda mentioned this issue Mar 9, 2023

Clippy wanted features & bugfixes Rust-for-Linux/linux#349

Open

46 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`new_ret_no_self` false positive when returning `impl Trait<Self>` #7344

`new_ret_no_self` false positive when returning `impl Trait<Self>` #7344

nbdd0121 commented Jun 11, 2021 •

edited by rustbot

Loading

nbdd0121 commented Oct 27, 2022

new_ret_no_self false positive when returning impl Trait<Self> #7344

new_ret_no_self false positive when returning impl Trait<Self> #7344

Comments

nbdd0121 commented Jun 11, 2021 • edited by rustbot Loading

nbdd0121 commented Oct 27, 2022

`new_ret_no_self` false positive when returning `impl Trait<Self>` #7344

`new_ret_no_self` false positive when returning `impl Trait<Self>` #7344

nbdd0121 commented Jun 11, 2021 •

edited by rustbot

Loading