Skip to content

format_push_string has an incorrect "Added in" version #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoav-lavi opened this issue Jul 1, 2022 · 2 comments · Fixed by #9085
Closed

format_push_string has an incorrect "Added in" version #9081

yoav-lavi opened this issue Jul 1, 2022 · 2 comments · Fixed by #9085
Assignees
@xFrednet

Comments

@yoav-lavi
Copy link
Contributor

yoav-lavi commented Jul 1, 2022 •
edited by rustbot
Loading

Description

The lint states Added in: 1.61.0, but the 1.62 changelog shows it as added in that version and in my anecdotal experience it only started to work in that version.

(This is my second issue regarding this lint, that's by chance, nothing against it in particular! Just happened to notice 🙂)

Version

rustc 1.62.0 (a8314ef7d 2022-06-27)
binary: rustc
commit-hash: a8314ef7d0ec7b75c336af2c9857bfaf43002bfc
commit-date: 2022-06-27
host: aarch64-apple-darwin
release: 1.62.0
LLVM version: 14.0.5

Additional Labels

No response
@xFrednet
Copy link
Member

xFrednet commented Jul 1, 2022

@rustbot claim

@xFrednet
Copy link
Member

xFrednet commented Jul 1, 2022

Thank you for the report, this is highly appreciated. We plan to improve our framework and prevent such mismatches, but that'll sadly still take some time. Until then these reports are really helpfull :)

@xFrednet xFrednet mentioned this issue Jul 1, 2022
Merged
bors added a commit that referenced this issue Jul 1, 2022
@bors
Auto merge of #9085 - xFrednet:9081-update-format-push-version, r=Man…
ad093d2 
…ishearth,flip1995

Correct lint version for `format_push_string`

Closes #9081

chaneglog: none

IDK what else to say. Look I can draw an ascii penguin =D:

```
 (^v^)
<(   )>
  w w
```
@bors bors closed this as completed in f30b68d Jul 1, 2022
@yoav-lavi yoav-lavi mentioned this issue Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xFrednet xFrednet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct lint version for format_push_string xFrednet/rust-clippy
2 participants
@yoav-lavi @xFrednet