Skip to content

Suggest unwrap_or_default when returning empty String in closure #9420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xphoniex opened this issue Sep 3, 2022 · 0 comments · Fixed by #9421
Closed

Suggest unwrap_or_default when returning empty String in closure #9420

xphoniex opened this issue Sep 3, 2022 · 0 comments · Fixed by #9421
Assignees
@xphoniex

Comments

@xphoniex
Copy link
Contributor

xphoniex commented Sep 3, 2022 •
edited by rustbot
Loading

Description

Clippy accepts this atm:

empty_string.unwrap_or_else(|| "".to_string());

It should suggest unwrap_or_default for this case, which is more concise:

empty_string.unwrap_or_default();

Version

No response

Additional Labels

@rustbot claim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xphoniex xphoniex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggest unwrap_or_default when closure returns "".to_string xphoniex/rust-clippy
1 participant
@xphoniex