-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix [invalid_regex
] not recognizing new syntax introduced after regex-1.8.0
#10682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
@bors r+ |
fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0 fixes: #10680 --- changelog: - bump up `regex-syntax` dependency version to 0.7.0 - fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0
💔 Test failed - checks-action_test |
@bors retry |
fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0 fixes: #10680 --- changelog: - bump up `regex-syntax` dependency version to 0.7.0 - fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0
💔 Test failed - checks-action_test |
Seems like CI doesn't like the changelog format since it's using grep. I edited to use the changelog that's user-facing and leave the dependency to additional info instead @bors retry |
hmmmm, seems like the bot is still mad at me 😆 , should I do something on my end? |
@J-ZhengLi Bors is on an unforeseen break at the moment 😅 Nothing that we can do for this PR other than wait for bors to be back up. You can follow the updates on Zulip though, if you're interested https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/What's.20up.20with.20bors |
Good to know that the bot can get tired sometimes~ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes: #10680
changelog: fix [
invalid_regex
] not recognizing new syntax introduced after regex-1.8.0bump up
regex-syntax
dependency version to 0.7.0