Skip to content

fix [invalid_regex] not recognizing new syntax introduced after regex-1.8.0 #10682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2023

Conversation

J-ZhengLi
Copy link
Member

@J-ZhengLi J-ZhengLi commented Apr 21, 2023

fixes: #10680


changelog: fix [invalid_regex] not recognizing new syntax introduced after regex-1.8.0

bump up regex-syntax dependency version to 0.7.0

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 21, 2023
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dswij
Copy link
Member

dswij commented May 11, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 11, 2023

📌 Commit 5fc1c79 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 11, 2023

⌛ Testing commit 5fc1c79 with merge 0af3315...

bors added a commit that referenced this pull request May 11, 2023
fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0

fixes: #10680

---

changelog:
- bump up `regex-syntax` dependency version to 0.7.0
- fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0
@bors
Copy link
Contributor

bors commented May 11, 2023

💔 Test failed - checks-action_test

@dswij
Copy link
Member

dswij commented May 11, 2023

@bors retry

@bors
Copy link
Contributor

bors commented May 11, 2023

⌛ Testing commit 5fc1c79 with merge 50b3252...

bors added a commit that referenced this pull request May 11, 2023
fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0

fixes: #10680

---

changelog:
- bump up `regex-syntax` dependency version to 0.7.0
- fix [`invalid_regex`] not recognizing new syntax introduced after regex-1.8.0
@bors
Copy link
Contributor

bors commented May 11, 2023

💔 Test failed - checks-action_test

@dswij
Copy link
Member

dswij commented May 15, 2023

Seems like CI doesn't like the changelog format since it's using grep. I edited to use the changelog that's user-facing and leave the dependency to additional info instead

@bors retry

@J-ZhengLi
Copy link
Member Author

J-ZhengLi commented May 16, 2023

Seems like CI doesn't like the changelog format since it's using grep. I edited to use the changelog that's user-facing and leave the dependency to additional info instead

@bors retry

hmmmm, seems like the bot is still mad at me 😆 , should I do something on my end?

@dswij
Copy link
Member

dswij commented May 16, 2023

hmmmm, seems like the bot is still mad at me 😆 , should I do something on my end?

@J-ZhengLi Bors is on an unforeseen break at the moment 😅

Nothing that we can do for this PR other than wait for bors to be back up. You can follow the updates on Zulip though, if you're interested

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/What's.20up.20with.20bors
https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20doesn't.20start.20builds.20on.20rust-analyzer

@J-ZhengLi
Copy link
Member Author

hmmmm, seems like the bot is still mad at me 😆 , should I do something on my end?

@J-ZhengLi Bors is on an unforeseen break at the moment 😅

Nothing that we can do for this PR other than wait for bors to be back up. You can follow the updates on Zulip though, if you're interested

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/What's.20up.20with.20bors https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20doesn't.20start.20builds.20on.20rust-analyzer

Good to know that the bot can get tired sometimes~

@bors
Copy link
Contributor

bors commented May 18, 2023

⌛ Testing commit 5fc1c79 with merge 223f518...

@bors
Copy link
Contributor

bors commented May 18, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 223f518 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex 1.8.0: Valid ?P<foo> -> ?<foo> triggers lint
4 participants