Skip to content

Explain which paths clippy searches for configuration in docs #10857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

MarcusGrass
Copy link
Contributor

Fixes #9921.

Adds information on where to place the configuration files, it may be a bit verbose. Also added a comment to the section of the code where the search happens, to hopefully prevent changing that without updating the docs.

changelog: Make documentation about where to place configuration files clearer.

@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 1, 2023
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on how to improve this slightly.

@MarcusGrass MarcusGrass requested a review from flip1995 June 1, 2023 10:54
@flip1995
Copy link
Member

flip1995 commented Jun 1, 2023

Thanks, an ordered list is even better.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 1, 2023

📌 Commit 194343f has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 1, 2023

⌛ Testing commit 194343f with merge 9524cff...

@bors
Copy link
Contributor

bors commented Jun 1, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 9524cff to master...

@bors bors merged commit 9524cff into rust-lang:master Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[documentation] Where to place clippy.toml is hard to find
4 participants