-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[incorrect_clone_impl_on_copy_type
]: Do not lint if only has MaybeUninit
fields
#11089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the lint group change, and there's one simplification I found. Otherwise this looks good to me.
Why complexity?
Because it seemed there was mostly agreement of it in #11072, I put it in In most cases, this is a complexity issue; like |
☔ The latest upstream changes (presumably #11122) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #11095) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm currently trying to catch up on my review queue. This looks good, pending a rebase. @bors delegate+ |
Hey this is triage, I'm closing this due to inactivity. Currently, @Centri3 sadly doesn't have the time to continue this implementation. If anyone is interested in continuing this PR, you're more than welcome to create a new PR and push it over the finish line. :D Thank you to @Centri3 and the reviewers for the time, that you already put into this! @rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review |
Closes #11072
Closes #11071
changelog: Enhancement: [
incorrect_clone_impl_on_copy_type
]: Do not lint if only hasMaybeUninit
fieldschangelog: Enhancement: [
incorrect_clone_impl_on_copy_type
]: Downgrade tocomplexity
changelog: Enhancement: [
incorrect_clone_impl_on_copy_type
]: Do not lintnever
-like enums