Skip to content

[unnecessary_literal_unwrap]: also lint unwrap_(err_)unchecked #11098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

y21
Copy link
Member

@y21 y21 commented Jul 3, 2023

Closes #11093

changelog: [unnecessary_literal_unwrap]: also lint unwrap_unchecked and unwrap_err_unchecked

@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 3, 2023
@Centri3
Copy link
Member

Centri3 commented Jul 3, 2023

This could probably check unwrap_err_unchecked as well

@y21 y21 changed the title [unnecessary_literal_unwrap]: also lint unwrap_unchecked [unnecessary_literal_unwrap]: also lint unwrap_(err_)unchecked Jul 3, 2023
@bors
Copy link
Contributor

bors commented Jul 9, 2023

☔ The latest upstream changes (presumably #11110) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks!

Can we resolve the conflicts?

@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jul 11, 2023

📌 Commit 0b5dac0 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 12, 2023

⌛ Testing commit 0b5dac0 with merge 3b43b1e...

@bors
Copy link
Contributor

bors commented Jul 12, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 3b43b1e to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FN unneccessary_literal_unwrap: unwrap_unchecked()
5 participants