Skip to content

Add test dependencies lock file #11137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 11, 2023

This should make the test suite more reliable. CI and new checkouts do not have a lockfile, so they pick up random new crates. This can cause build breakage and random test failures if someone on crates.io breaks semver accidentally. After this PR there should be no more issues like that.

changelog: use Cargo.lock for our test suite's dependencies

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 11, 2023
@flip1995
Copy link
Member

I guess this is a good chance to point out #11045

@oli-obk oli-obk closed this Jul 12, 2023
@oli-obk oli-obk deleted the ui_test branch July 12, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants