Skip to content

fix: broken GitHub corner #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2023
Merged

fix: broken GitHub corner #11947

merged 2 commits into from
Dec 17, 2023

Conversation

hamirmahal
Copy link
Contributor

changelog: none

fixes #11946

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 10, 2023
@hamirmahal
Copy link
Contributor Author

Without this change

Screencast.from.12-10-2023.01.38.40.AM.webm

With this change

Screencast.from.12-10-2023.01.41.08.AM.webm

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you separate the formatting changes from the changes that fix the corner?

@hamirmahal
Copy link
Contributor Author

Sure, I'll take a look now.

@hamirmahal hamirmahal requested a review from blyxyas December 10, 2023 23:45
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked in a browser to see that it's responsive enough, but the code seems fine (that checking step is pretty crucial, but I'm sure Fred will take care of that) (=^‥^=)

@xFrednet
Copy link
Member

Hey, I'm sadly busy this week, but I'll be able to review this on the weekend. Sorry for the delay.

@xFrednet
Copy link
Member

Works excellent and the small wave is super cute. Thank you for the update!

@bors r=blyxyas,xFrednet

@bors
Copy link
Contributor

bors commented Dec 17, 2023

📌 Commit 3168bcf has been approved by blyxyas,xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 17, 2023

⌛ Testing commit 3168bcf with merge 7e650b7...

@bors
Copy link
Contributor

bors commented Dec 17, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas,xFrednet
Pushing 7e650b7 to master...

@bors bors merged commit 7e650b7 into rust-lang:master Dec 17, 2023
@hamirmahal hamirmahal deleted the fix/broken-GitHub-corner branch December 17, 2023 21:40
@hamirmahal
Copy link
Contributor Author

Works excellent and the small wave is super cute. Thank you for the update!

@bors r=blyxyas,xFrednet

You're welcome! I'm glad you like it. It's from https://tholman.com/github-corners/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken GitHub Corner on Clippy Lints page
5 participants