-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: broken GitHub corner #11947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken GitHub corner #11947
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Without this changeScreencast.from.12-10-2023.01.38.40.AM.webmWith this changeScreencast.from.12-10-2023.01.41.08.AM.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you separate the formatting changes from the changes that fix the corner?
Sure, I'll take a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked in a browser to see that it's responsive enough, but the code seems fine (that checking step is pretty crucial, but I'm sure Fred will take care of that) (=^‥^=)
Hey, I'm sadly busy this week, but I'll be able to review this on the weekend. Sorry for the delay. |
Works excellent and the small wave is super cute. Thank you for the update! @bors r=blyxyas,xFrednet |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
You're welcome! I'm glad you like it. It's from https://tholman.com/github-corners/. |
changelog: none
fixes #11946