Skip to content

Conversation

@samueltardieu
Copy link
Member

This applies to Arc, Rc, and their weak variants. Using .clone() would be less idiomatic.

This follows the discussion in #12528 (comment).

changelog: [useless_asref]: do not lint .as_ref().map(Arc::clone) and similar

@rustbot
Copy link
Collaborator

rustbot commented Mar 22, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 22, 2024
@samueltardieu
Copy link
Member Author

r? @y21

@rustbot rustbot assigned y21 and unassigned Manishearth Mar 22, 2024
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, good idea to move it to utils

r=me with (or without if it doesn't make sense) doc nit fixed

@samueltardieu
Copy link
Member Author

@bors r=y21

@bors
Copy link
Contributor

bors commented Mar 23, 2024

@samueltardieu: 🔑 Insufficient privileges: Not in reviewers

@samueltardieu
Copy link
Member Author

@bors r=y21

I don't have the needed privileges, maybe you could have used delegate+

@y21
Copy link
Member

y21 commented Mar 23, 2024

oops, my bad 😅

Thanks, looks good!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 23, 2024

📌 Commit fed2f28 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 23, 2024

⌛ Testing commit fed2f28 with merge 12f7c17...

@bors
Copy link
Contributor

bors commented Mar 23, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 12f7c17 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants