Don't trigger const_is_empty lint inside const blocks
#13114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
This does mean that we're going to ignore all const blocks, e.g. this is going to be ignored too. const {
"".is_empty();
}Is there an alternative we can do? I think we can also check for |
|
You have a good point. |
|
Thanks for taking the time to open this PR! |
bors
added a commit
that referenced
this pull request
Oct 20, 2024
Don't trigger `const_is_empty` for inline const assertions Close #13106 Considered case was described [here](#13114 (comment)) changelog [`const_is_empty`]: skip const_is_empty for inline const assertions
bors
added a commit
that referenced
this pull request
Oct 22, 2024
Don't trigger `const_is_empty` for inline const assertions Close #13106 Considered case was described [here](#13114 (comment)) changelog [`const_is_empty`]: skip const_is_empty for inline const assertions
bors
added a commit
that referenced
this pull request
Oct 24, 2024
Don't trigger `const_is_empty` for inline const assertions Close #13106 Considered case was described [here](#13114 (comment)) changelog: [`const_is_empty`]: skip const_is_empty for inline const assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
const_is_empty] Don't trigger lint inside const blocksFixes #13106 .