Add internal lint to check for slow symbol comparisons#13543
Merged
bors merged 4 commits intorust-lang:masterfrom Oct 18, 2024
Merged
Add internal lint to check for slow symbol comparisons#13543bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
the
S-waiting-on-review
Contributor
|
You may want to run |
GnomedDev
force-pushed
the
symbol-comparisons
branch
3 times, most recently
from
614d489 to
dc7de29
Compare
Member
|
This pattern is still recommended in a few places throughout the clippy book, so if we're going to actively lint against this we should also update those as well (searching for |
Contributor
|
☔ The latest upstream changes (presumably #13540) made this pull request unmergeable. Please resolve the merge conflicts. |
y21
reviewed
Oct 13, 2024
clippy_lints/src/utils/internal_lints/slow_symbol_comparisons.rs
Outdated
Show resolved
Hide resolved
Member
|
Can you also add a basic test for this lint? |
GnomedDev
force-pushed
the
symbol-comparisons
branch
from
dc7de29 to
9e8480e
Compare
Contributor
Author
|
Done, added a test. @y21 |
y21
approved these changes
Oct 13, 2024
Member
y21
left a comment
y21
left a comment
There was a problem hiding this comment.
Looks good, just a small remark on the book changes
GnomedDev
force-pushed
the
symbol-comparisons
branch
from
6a33e8d to
c7abeb9
Compare
GnomedDev
force-pushed
the
symbol-comparisons
branch
from
c7abeb9 to
979e297
Compare
Member
|
Looks good now, thanks! @bors r+ |
Contributor
y21
approved these changes
Oct 18, 2024
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the conversation on Zulip.
changelog: none