collect attribute spans early for disallowed macros#13657
Merged
flip1995 merged 1 commit intoNov 7, 2024
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
Contributor
Author
|
r? @flip1995 |
jdonszelmann
force-pushed
the
disallowed-macros-to-early
branch
from
7ba793c to
c931096
Compare
GuillaumeGomez
approved these changes
Nov 5, 2024
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
Member
There was a problem hiding this comment.
As said on the original PR: looks good to me, thanks!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filed here instead of rust-lang/rust (old: rust-lang/rust#132645)
changelog: none