Skip to content

clippy_utils: Make sym_helper module private #13731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

BD103
Copy link
Contributor

@BD103 BD103 commented Nov 26, 2024

This is a small PR that makes clippy_utils::sym_helper private. Since this module only contains a single macro, sym!, which is already re-exported at the root with #[macro_export], there's no need for the module to be public.

changelog: none

  • cargo test passes locally
  • Run cargo dev fmt

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 26, 2024
@BD103 BD103 changed the title Make sym_helper module private in clippy_utils clippy_utils: Make sym_helper module private Nov 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2025

☔ The latest upstream changes (possibly cc00c77) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

Merge conflicts need to be fixed

@y21
Copy link
Member

y21 commented Apr 21, 2025

The conflicting PR #14650 removed the sym! macro and the sym_helper module along with it, so I don't think there is anything that could be done here anymore

@Manishearth
Copy link
Member

Ah. Thanks for your efforts in this PR, sorry it's no longer necessary!

@Manishearth
Copy link
Member

@y21 heh, I was wondering what would cause a one liner to conflict, but I couldn't see the conflicts on mobile

@BD103
Copy link
Contributor Author

BD103 commented Apr 21, 2025

Ah. Thanks for your efforts in this PR, sorry it's no longer necessary!

No worries! :)

@BD103 BD103 deleted the private-sym-helper branch April 21, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants