Fixes manual_slice_size_computation ICE and triggers in const context
#14804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, a dereference is needed before using `mem::size_of_val()`.
rustbot
added
the
S-waiting-on-review
samueltardieu
changed the title
manual_slice_size_computation ICE and triggers in const contextmanual_slice_size_computation ICE and triggers in const context
y21
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes #14802: when a slice is directly present, it must be dereferenced (instead of referenced -1 times) before being passed to
mem::size_of_val().The second commit triggers the lint in a
constcontact when MSRV ≥ 1.85.changelog: [
manual_slice_size_computation]: fix ICE in suggestion to efficiently compute the size of a slice, and trigger the lint inconstcontext as well