only require rustfmt and update_lints for version bumps #1538
Conversation
| - Write a changelog entry. | ||
| - Commit `./Cargo.toml`, `./clippy_lints/Cargo.toml` and `./CHANGELOG.md`. | ||
| - Review and commit all changed files |
There was a problem hiding this comment.
I prefer to have one commit just for the version bump itself,that is the Cargo.tomls and the changelog.
There was a problem hiding this comment.
I changed the script to do this for us
pre_publish.sh
Outdated
| set -e | ||
|
|
||
| cd clippy_lints && cargo fmt && cd .. | ||
| cargo fmt |
There was a problem hiding this comment.
Can it add --write-mode=overwrite if the repo is clean? I hate those .bk files
pre_publish.sh
Outdated
|
|
||
| # add all changed files | ||
| git add . | ||
| git commit -m "version bump" |
There was a problem hiding this comment.
This definitely needs to contain the version then. Also, this fails rules 3 and 5.
There was a problem hiding this comment.
we tag it later, do we really need the version in there?
|
any further complaints? or can we merge this? |
|
should we move dogfood tests to version bumps, too? |
|
No. They are good to see the effect of a new lint on a real codebase. See #1556 for example, dogfood shows quite a few nice examples of what the lint does. |
|
I'm also bullish in dogfooding. |
|
Yay! \o/ |
fixes #1487