Add duration_subsec lint #2839
Merged
Add duration_subsec lint #2839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2543
ghost
mentioned this pull request
oli-obk
reviewed
Jun 10, 2018
clippy_lints/src/duration_subsec.rs
Outdated
| if let Some((Constant::Int(divisor), _)) = constant(cx, cx.tables, right); | ||
| then { | ||
| let suggested_fn = match divisor { | ||
| 1_000 => "subsec_micros", |
There was a problem hiding this comment.
I think we could also complain about subsec_micros() / 1000 and similar other usages that have a dedicated method. You should be able to do this nicely by matching on (method_path.name.as_str(), divisor) to check all combinations that we want to lint
|
I made the changes suggested by @oli-obk . |
|
Sweet! Thanks |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2543