Skip to content

Document how to lint local Clippy changes with locally built Clippy #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2018

Conversation

waynr
Copy link
Contributor

@waynr waynr commented Nov 21, 2018

No description provided.

@mati865
Copy link
Contributor

mati865 commented Nov 21, 2018

Doesn't cargo test already do it?

@waynr
Copy link
Contributor Author

waynr commented Nov 21, 2018

@mati865 I see that there is a "dogfood" test case, but it's not quite the same as the command shown in this PR and it doesn't seem to report when the command shown in this PR does. For an example of when I would expect a problem to be reported by the command shown in this PR, see this PR:
https://github.com/rust-lang-nursery/rust-clippy/pull/3437/commits

And specifically, compare the result of cargo test and the command I added in this PR when run against this commit:
ca48031

Maybe we could fix the dogfood test case and remove https://github.com/rust-lang-nursery/rust-clippy/blob/64ff255ac63856c1dfe2021a62349984e4039788/ci/base-tests.sh#L30-L32/

@flip1995
Copy link
Member

dogfood should do that but it seems that dogfood doesn't catch as many errors as running clippy itself.

See
https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/457767388#L1474
vs
https://travis-ci.org/rust-lang-nursery/rust-clippy/jobs/457767388#L1211

@flip1995
Copy link
Member

Maybe we could fix the dogfood test case and remove

That would be a good solution. But as long as dogfood doesn't behave as it should, we should add this to the docs.

bors r+

bors bot added a commit that referenced this pull request Nov 21, 2018
3443: Document how to lint local Clippy changes with locally built Clippy r=flip1995 a=waynr



Co-authored-by: Wayne Warren <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 21, 2018

@bors bors bot merged commit 4450b3e into rust-lang:master Nov 21, 2018
@waynr waynr mentioned this pull request Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants