Adds inequality cases to bool comparison (#3438) #3473
Conversation
clippy_lints/src/needless_bool.rs
Outdated
| } | ||
| } else if let ExprKind::Binary( | ||
| Spanned { | ||
| node: BinOpKind::Ne, .. |
There was a problem hiding this comment.
since the only difference is the type of operation and some error messages, can you try to deduplicate this code with the above code? Mayne by moving it out into a function
There was a problem hiding this comment.
I was thinking, considering the difference in suggesting !hint or hint, on passing a closure (Fn(Sugg) -> Sugg) such as |hint| !hint.
Do you think there is a more idiomatic way of doing this?
There was a problem hiding this comment.
Do you think there is a more idiomatic way of doing this?
Nope, that sounds good to me if that solves all the duplication.
lucasloisp
force-pushed
the
additional-bool-comparisons
branch
3 times, most recently
from
31cfea5 to
3964b08
Compare
phansch
added
the
S-waiting-on-review
clippy_lints/src/needless_bool.rs
Outdated
| e: &'tcx Expr, | ||
| true_message: &str, | ||
| false_message: &str, | ||
| true_hint: F, |
There was a problem hiding this comment.
just a nit: remove the generic parameters and replace their uses in the argument list with impl FnOnce(Sugg<'_>) -> Sugg<'_>
|
r=me with nit fixed |
flip1995
added
S-waiting-on-author
The lint now checks cases like `y != true`
lucasloisp
force-pushed
the
additional-bool-comparisons
branch
from
3964b08 to
3930148
Compare
phansch
added
S-waiting-on-review
|
LGTM, thanks! |
4 participants
The lint now checks cases like
y != true, as suggested by the issue #3438.Other cases talked about in the issue (i.e.
x < yvs!x && y) are not implemented by this PR.I can do so if you prefer that the whole issue is closed at once but I might need a little guidance (I will give it a try meanwhile).
Please let me know of any changes necessary