Add "unnecessary mut passed" lint #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| ExprMethodCall(ref name, _, ref arguments) => { | ||
| let method_call = MethodCall::expr(e.id); | ||
| let borrowed_table = cx.tcx.tables.borrow(); |
There was a problem hiding this comment.
These two blocks are almost duplicated. It should be possible to factor the common code out into a helper method.
|
A few test cases would be nice :) |
|
Thanks for the feedback 😄. I'm still a bit new to rust, but it get's better every day. |
|
Any idea why this build is failing? The file that the compiler complained about hasn't changed. |
|
We needed a rustup. Fixed |
Manishearth
added a commit
that referenced
this pull request
Oct 6, 2015
Add "unnecessary mut passed" lint
|
Sorry about forgetting about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the first lint mentioned in issue #353. I tested it on some external crates (racer, winapi-rs, ...) and some of my own projects, seems to work properly.
Note that this doesn't work for methods currently.
Edit: It does now.