Prevent incorrect cast_lossless suggestion in const_fn #3700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`::from` is not a const fn, so applying the suggestion of `cast_lossless` would fail to compile. The fix is to skip the lint if the cast is found inside a const fn.
phansch
force-pushed
the
would_you_like_some_help_with_this_const_fn
branch
from
7e5f04b to
8c416c3
Compare
phansch
added
the
S-waiting-on-review
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 8c416c3 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jan 28, 2019
…t_fn, r=oli-obk Prevent incorrect cast_lossless suggestion in const_fn `::from` is not a const fn, so applying the suggestion of `cast_lossless` would fail to compile. The fix is to skip the lint if the cast is found inside a const fn. Fixes #3656
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::fromis not a const fn, so applying the suggestion ofcast_losslesswould fail to compile. The fix is to skip the lint ifthe cast is found inside a const fn.
Fixes #3656