Skip to content

Fix dogfood tests on Appveyor #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jan 26, 2019
Merged

Fix dogfood tests on Appveyor #3701

merged 1 commit into from Jan 26, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2019

This introduces a work-around for a bug in rustup.rs when excuting
cargo from a custom toolchain. Instead of trusting rustup to
invoke cargo from one of the release channels we just invoke
nightly cargo directly.

This introduces a work-around for a bug in rustup.rs when excuting
cargo from a custom toolchain. Instead of trusting rustup to
invoke cargo from one of the release channels we just invoke
nightly cargo directly.
@phansch
Copy link
Member

phansch commented Jan 26, 2019

LGTM, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jan 26, 2019

📌 Commit 94a6eb0 has been approved by phansch

@bors
Copy link
Contributor

bors commented Jan 26, 2019

⌛ Testing commit 94a6eb0 with merge b1b55e8...

bors added a commit that referenced this pull request Jan 26, 2019
Fix dogfood tests on Appveyor

This introduces a work-around for a bug in rustup.rs when excuting
cargo from a custom toolchain. Instead of trusting rustup to
invoke cargo from one of the release channels we just invoke
nightly cargo directly.
@bors
Copy link
Contributor

bors commented Jan 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing b1b55e8 to master...

@bors bors merged commit 94a6eb0 into rust-lang:master Jan 26, 2019
@ghost ghost deleted the fix-3118 branch May 11, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants