Lint pass macros

[kraai]

No description provided.

[flip1995]

There are some files untouched, e.g. clippy_lints/src/unwrap.rs and clippy_lints/src/ptr_offset_with_cast.rs. Others? *)

Some things I noticed by going through these changes, that need to be addressed in one way or another.

---

*) LintPass is still implemented by hand for this 2 files above. For both files this is not necessary. I assume you missed those by searching for impl LintPass with a regexp. In clippy_lints/src/ptr_offset_with_cast.rs the imports should be fixed.

[kraai]

There are some files untouched, e.g. clippy_lints/src/unwrap.rs and clippy_lints/src/ptr_offset_with_cast.rs. Others? *)

Some things I noticed by going through these changes, that need to be addressed in one way or another.

*) LintPass is still implemented by hand for this 2 files above. For both files this is not necessary. I assume you missed those by searching for impl LintPass with a regexp. In clippy_lints/src/ptr_offset_with_cast.rs the imports should be fixed.

Oops, I searched for impl LintPass so I didn't catch those. Thanks for finding them.

[flip1995]

cc #3968 (comment)

It seems that it doesn't trigger the module_name_repetition lint

[flip1995]

This LGTM now! Thanks for the quick fixes.

Could you extend the test file tests/ui/lint_without_lint_pass.rs by adding 2 LintPass definitions with those macros (declare/impl_lint_pass)?

[bors]

☔ The latest upstream changes (presumably #3966) made this pull request unmergeable. Please resolve the merge conflicts.

[flip1995]

Thanks! Just needs a rebase.

[kraai]

@flip1995 I'm trying to rebase it now.

[flip1995]

Thanks!

@bors r+ p=1

[bors]

📌 Commit ef29db7 has been approved by flip1995

[bors]

⌛ Testing commit ef29db7 with merge 58e1213...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 58e1213 to master...