Skip to content

Make most macro checks also check for desugarings #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
May 12, 2019
Merged

Make most macro checks also check for desugarings #4082

bors merged 2 commits into from
May 12, 2019

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented May 12, 2019

We should audit the macro checks one by one and re-add in_macro. I suspect it's applicable to most of them.

fixes #4081

@Manishearth
Copy link
Member Author

Manishearth commented May 12, 2019

I don't have a regression test in here because the issue had a proc macro, might add one later.

@Manishearth Manishearth mentioned this pull request May 12, 2019
Open
@oli-obk
Copy link
Contributor

oli-obk commented May 12, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2019

📌 Commit abf6481 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented May 12, 2019

⌛ Testing commit abf6481 with merge feb18c3...

bors added a commit that referenced this pull request May 12, 2019
@bors
Auto merge of #4082 - Manishearth:macro-check-split, r=oli-obk
feb18c3 
Make most macro checks also check for desugarings

We should audit the macro checks one by one and re-add `in_macro`. I suspect it's applicable to most of them.

fixes #4081
@bors
Copy link
Contributor

bors commented May 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing feb18c3 to master...

@bors bors merged commit abf6481 into rust-lang:master May 12, 2019
This was referenced May 12, 2019
Closed
Closed
Merged
bors added a commit that referenced this pull request May 12, 2019
@bors
Auto merge of #4089 - flip1995:id_conv_reg_test, r=Manishearth
c79838e 
Add regression test for identity_conversion FP

cc #3913 #4082 #3936

changelog: none
@Manishearth
Copy link
Member Author

Manishearth commented May 12, 2019

oops forgot to changelog

@Manishearth Manishearth deleted the macro-check-split branch May 12, 2019 19:38
@flip1995 flip1995 mentioned this pull request May 15, 2019
Closed
@flip1995 flip1995 mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive: identity_conversion on macro-generated ?

3 participants

@Manishearth @oli-obk @bors