Skip to content

Rustup HirIdification #4254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2019
Merged

Rustup HirIdification #4254

merged 3 commits into from
Jul 6, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jul 6, 2019

Rustup rust-lang/rust#62168

changelog: none

@Manishearth
Copy link
Member

We should still have the lint; we should #[allow(deprecated)] in the file.

@ghost
Copy link

ghost commented Jul 6, 2019

Do we really need a lint to tell people not to use a deprecated constant? I don't see what value it adds.

@Manishearth
Copy link
Member

I guess not

@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2019

📌 Commit 4814991 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Jul 6, 2019

⌛ Testing commit 4814991 with merge 8744e8e...

bors added a commit that referenced this pull request Jul 6, 2019
@bors
Copy link
Contributor

bors commented Jul 6, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 8744e8e to master...

@bors bors merged commit 4814991 into rust-lang:master Jul 6, 2019
@tesuji tesuji deleted the hiridification-62168 branch July 6, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants