write_with_newline now handles \r\n

[bookshelfdave]

fixes #4208
changelog: write_with_newline now handles \r\n

based off of matthiaskrgr@588dcc8

[bookshelfdave]

build failures don't appear to be related to this PR:

error[E0425]: cannot find function `report_ices_to_stderr_if_any` in crate `rustc_driver`
   --> src/driver.rs:251:23
    |
251 |         rustc_driver::report_ices_to_stderr_if_any(move || {
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `rustc_driver`

[flip1995]

Thanks, waiting for the rustup.

[ghost]

Does it handle "\\r\n"?

[flip1995]

It should lint on \\r\n, since

"\\r\n" == r"\r
"

ping @metadave can you add a test for this?

[bookshelfdave]

yes, I'll try to add that some time today. I'm having issues getting it to compile related to #4547 (comment), any tips for getting the right version to build with?

[flip1995]

With RTIM you can install the master toolchain or just run setup-toolchain.sh script in the repo root. If you already use the master toolchain, you can just rebase on the master branch.

$ git fetch upstream # where upstream is the remote of this repo
$ git rebase upstream/master # This should work without conflicts
$ git push --force-with-lease

After this cargo +master check should run without errors.

[HKalbasi]

finished in #4769
@rustbot label -S-inactive-closed