Skip to content

[WIP] Fixes issue 5095 #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

xiongmao86
Copy link
Contributor

Fixes #5095.

Check list:

  • Followed lint naming conventions
  • Added passing UI tests (including committed .stderr file)
  • cargo test passes locally
  • Executed cargo dev update_lints
  • Added lint documentation
  • Run cargo dev fmt

changelog: checking for collapsible span_lint_and_then calls.

@xiongmao86
Copy link
Contributor Author

It looks very intimidating, and I solved some of them, but I really don't know how to setup Span and LintContext.

@xiongmao86
Copy link
Contributor Author

Oh, there are place for internal lint clippy_lints/src/utils/internal_lints.rs.

@xiongmao86
Copy link
Contributor Author

xiongmao86 commented Feb 2, 2020

I have messed up with setting up test, the commits are heading the wrong way, thus abandoning this pr.

@xiongmao86 xiongmao86 closed this Feb 2, 2020
@xiongmao86 xiongmao86 deleted the issue5095 branch February 2, 2020 06:31
@flip1995
Copy link
Member

flip1995 commented Feb 2, 2020

Thanks for implementing this! If you want to start over and have any questions, I'm happy to answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal lint: check if span_lint_and_then and span_* are collapsable
2 participants