Lint category macro-ception #6830
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hmm.. I don't really like this. It makes this simple piece of code so much more complex. I think the code duplication is fine here, since this is a part of code that almost never has to be touched. So I prefer the simplicity over DRY in this case. |
|
I know what you mean. I could make it a tad simpler by inlining the categories macro? |
|
I changed it. But feel free to close. |
|
Yeah I kinda agree with flip here. The trick is cool, but I think readability matters more than DRY here |
xFrednet
added a commit
to xFrednet/rust-clippy
that referenced
this pull request
Feb 13, 2022
This is a revival of rust-lang#6830. It was closed to keep the currently simple implementation. However, with the upcoming changes it's better to follow the DRY princliple. Co-authored-by: camsteffen <[email protected]>
xFrednet
added a commit
to xFrednet/rust-clippy
that referenced
this pull request
Feb 14, 2022
This change was initially suggested by `@camsteffen` in rust-lang#6830. Back then, it was decided to avoid this change for simplicity. Now, I think it's reasonable to have it to avoid several repetitions for nightly lints. Co-authored-by: camsteffen [email protected]
xFrednet
added a commit
to xFrednet/rust-clippy
that referenced
this pull request
Feb 15, 2022
This was first suggested by `@camsteffen` in rust-lang#6830. Back then, it was decided to avoid this implementation to keep the macro simple. Now it makes sense to again use this macro, as the implementation of the macro will get a bit more complicated to support nightly lints. Credit where credit is due: Co-authored-by: camsteffen <[email protected]>
xFrednet
added a commit
to xFrednet/rust-clippy
that referenced
this pull request
Feb 17, 2022
This was first suggested by `@camsteffen` in rust-lang#6830. Back then, it was decided to avoid this implementation to keep the macro simple. Now it makes sense to again use this macro, as the implementation of the macro will get a bit more complicated to support nightly lints. Credit where credit is due: Co-authored-by: camsteffen <[email protected]>
xFrednet
added a commit
to xFrednet/rust-clippy
that referenced
this pull request
Feb 17, 2022
This was first suggested by `@camsteffen` in rust-lang#6830. Back then, it was decided to avoid this implementation to keep the macro simple. Now it makes sense to again use this macro, as the implementation of the macro will get a bit more complicated to support nightly lints. Credit where credit is due: Co-authored-by: camsteffen <[email protected]>
xFrednet
added a commit
to xFrednet/rust-clippy
that referenced
this pull request
Feb 17, 2022
This was first suggested by `@camsteffen` in rust-lang#6830. Back then, it was decided to avoid this implementation to keep the macro simple. Now it makes sense to again use this macro, as the implementation of the macro will get a bit more complicated to support nightly lints. Credit where credit is due: Co-authored-by: camsteffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none
Caution: The speed of time reduces by a factor of two with each nested macro invocation.