Skip to content

Conversation

@Manishearth
Copy link
Member

No description provided.

src/entry.rs Outdated
let sole_expr = else_block.is_none() &&
if then_block.expr.is_some() { 1 } else { 0 } + then_block.stmts.len() == 1;
if then_block.expr.is_some() {
1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, just noticed that too. Fixed the code.

@Manishearth Manishearth force-pushed the fmt branch 2 times, most recently from df3acb2 to ff82c5b Compare February 29, 2016 11:27
match_type(cx, ty, &BTREEMAP_PATH) ||
match_type(cx, ty, &["collections", "binary_heap", "BinaryHeap"]) || match_type(cx, ty, &BTREEMAP_PATH) ||
match_type(cx, ty, &["collections", "btree", "set", "BTreeSet"])
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the version with one match per line.

@Manishearth Manishearth force-pushed the fmt branch 3 times, most recently from 88e25a6 to c154d45 Compare February 29, 2016 11:36
Manishearth added a commit that referenced this pull request Feb 29, 2016
@Manishearth Manishearth merged commit e4b3cbb into master Feb 29, 2016
@Manishearth Manishearth deleted the fmt branch February 29, 2016 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants