fix bug for large_enum_variants#7677
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 30, 2021
Merged
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
camsteffen
reviewed
Sep 18, 2021
camsteffen
reviewed
Sep 21, 2021
camsteffen
suggested changes
Sep 22, 2021
camsteffen
reviewed
Sep 27, 2021
camsteffen
reviewed
Sep 27, 2021
camsteffen
reviewed
Sep 27, 2021
camsteffen
reviewed
Sep 28, 2021
camsteffen
approved these changes
Sep 29, 2021
Contributor
camsteffen
left a comment
camsteffen
left a comment
There was a problem hiding this comment.
Looking good! Please squash commits.
surechen
force-pushed
the
edit_large_enum_variant
branch
from
5bef29b to
56f0c9a
Compare
Contributor
Author
Done. Thanks. |
Contributor
|
@bors r+ Thanks! |
Contributor
|
📌 Commit 56f0c9a has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 30, 2021
fix bug for large_enum_variants Fix the discussion problem in the issue of #7666 (comment) About the false positive problem of case: ```rust enum LargeEnum6 { A, B([u8;255]), C([u8;200]), } ```
Contributor
|
💔 Test failed - checks-action_test |
Contributor
|
@bors retry Added changelog |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the discussion problem in the issue of #7666 (comment)
About the false positive problem of case:
changelog: Fix largest_enum_variant wrongly identifying the second largest variant.