-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New lint swap_ptr_to_ref
#8916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lint swap_ptr_to_ref
#8916
Conversation
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
fb96e75
to
5032d42
Compare
☔ The latest upstream changes (presumably #8918) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really neat lint!
one small issue, then feel free to r=me
} | ||
} | ||
|
||
fn is_ptr_to_ref(cx: &LateContext<'_>, e: &Expr<'_>, ctxt: SyntaxContext) -> (bool, Option<Span>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: documentation
@bors delegate+ |
✌️ @Jarcho can now approve this pull request |
I switched the category to |
@bors r=Manishearth |
📌 Commit ca78e24 has been approved by |
good call! |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes: #7381
changelog: New lint
swap_ptr_to_ref