Skip to content

Fix hang in vec_init_then_push #9441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix hang in vec_init_then_push #9441

merged 1 commit into from
Sep 7, 2022

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Sep 7, 2022

fixes #9433
changelog: Fix infinite loop in vec_init_then_push

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 7, 2022
@Alexendoo
Copy link
Member

👍

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2022

📌 Commit 1585932 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 7, 2022

⌛ Testing commit 1585932 with merge da29f89...

@bors
Copy link
Contributor

bors commented Sep 7, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing da29f89 to master...

@bors bors merged commit da29f89 into rust-lang:master Sep 7, 2022
@Jarcho Jarcho added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 13, 2022
@flip1995
Copy link
Member

This issue probably already exists for quite some time. The fix will get into beta anyway. We might want to backport this hang fix to beta, so it will hit stable next week. Since the fix is pretty small, I'll probably do that.

@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Sep 14, 2022
@flip1995
Copy link
Member

rust-lang/rust#101808

@Jarcho
Copy link
Contributor Author

Jarcho commented Sep 14, 2022

It would be since #8699.

@flip1995 flip1995 removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy hangs
5 participants
@Jarcho @rust-highfive @Alexendoo @bors @flip1995