[needless_return] Recursively remove unneeded semicolons
#9497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
Sep 21, 2022
kraktus
force-pushed
the
needless_return2
branch
from
65b023b to
b333645
Compare
Mark-Simulacrum
force-pushed
the
needless_return2
branch
2 times, most recently
from
a73376c to
b333645
Compare
|
@llogiq can you re-approve this PR? We're fixing some bors missing events (which is why I closed/opened it etc); see https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/bors.20stuck.20for.20Miri.20and.20other.20tools.3F for some additional context. |
|
Sure! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8336,
fix #8156,
fix #7358,
fix #9192,
fix #9503
changelog: [
needless_return] Recursively remove unneeded semicolonsFor now the suggestion about removing the semicolons are hidden because they would be very noisy and should be obvious if the user wants to apply the lint manually instead of using
--fix. This could be an issue for beginner, but haven't found better way to display it.