Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented May 6, 2024

In a similar vein to rust-lang/rustc-dev-guide#1889.

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2024

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2024
@ehuss
Copy link
Contributor

ehuss commented May 6, 2024

Updating this sounds great. However, users are probably more likely to see the message posted by the bot (source in no_merges.rs), which would probably be good to keep in sync here.

@Kobzol
Copy link
Member Author

Kobzol commented May 6, 2024

Did that here.

@Kobzol Kobzol requested a review from ehuss May 27, 2024 13:41
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kobzol Kobzol merged commit d3a264b into rust-lang:master May 27, 2024
@Kobzol Kobzol deleted the rebase branch May 27, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants