Update assembly filter to handle LLVM comments #407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406
The LLVM comments recently added to assembly are not handled by the existing filtering scripts, causing some labels to be removed incorrectly.
This commit makes the following updates:
# %bb
comments as seen in the example below. I'm not sure how much utility they provide, but they also don't create too much noise..p2align
directives, but still retains the standalone "End function" comments. I don't think this will be confusing as the filtering makes it easy to tell which function we're in. Below is an example for reference:Raw
Filtered