Skip to content

Remove "Open an issue" link #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Remove "Open an issue" link #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/spec/features/sharing_with_others_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
perma_link = find_link("Permalink to the playground")[:href]
direct_link = find_link("Direct link to the gist")[:href]
urlo_link = find_link("Open a new thread in the Rust user forum")[:href]
issue_link = find_link("Open an issue on the Rust GitHub repository")[:href]

# Navigate away so we can tell that we go back to the same page
visit 'about:blank'
Expand All @@ -41,10 +40,6 @@
# Need to be logged in to URLO for this link to work
expect(urlo_link).to match(%r{https://users.rust-lang.org/new-topic})
expect(urlo_link).to match(%{automated%20test})

# Need to be logged in to GitHub for this link to work
expect(issue_link).to match(%r{https://github.com/rust-lang/rust/issues/new})
expect(issue_link).to match(%{automated%20test})
end

def editor
Expand Down
2 changes: 0 additions & 2 deletions ui/frontend/Output/Gist.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ class Copied extends React.PureComponent<CopiedProps, CopiedState> {
const Links: React.SFC = () => {
const codeUrl = useSelector(selectors.codeUrlSelector);
const gistUrl = useSelector((state: State) => state.output.gist.url);
const issueUrl = useSelector(selectors.issueUrlSelector);
const permalink = useSelector(selectors.permalinkSelector);
const urloUrl = useSelector(selectors.urloUrlSelector);

Expand All @@ -65,7 +64,6 @@ const Links: React.SFC = () => {
<Copied href={gistUrl}>Direct link to the gist</Copied>
<Copied href={codeUrl}>Embedded code in link</Copied>
<NewWindow href={urloUrl}>Open a new thread in the Rust user forum</NewWindow>
<NewWindow href={issueUrl}> Open an issue on the Rust GitHub repository</NewWindow>
</Fragment>
);
};
Expand Down
9 changes: 0 additions & 9 deletions ui/frontend/selectors/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,15 +237,6 @@ export const urloUrlSelector = createSelector(
},
);

export const issueUrlSelector = createSelector(
snippetSelector,
snippet => {
const newIssueUrl = url.parse('https://github.com/rust-lang/rust/issues/new', true);
newIssueUrl.query = { body: snippet };
return url.format(newIssueUrl);
},
);

export const codeUrlSelector = createSelector(
baseUrlSelector, urlQuerySelector, gistSelector,
(baseUrl, query, gist) => {
Expand Down