-
Notifications
You must be signed in to change notification settings - Fork 222
♪ EditiooOoOOnnN ! ♫ #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♪ EditiooOoOOnnN ! ♫ #739
Conversation
One thing I think we should also add is a notification popup to let people know that 2021 is live and the default. We should:
I don't have a great idea for the notification text or silence date, though. |
Yes, indeed, good point about the notification. You had added one last time, for the 2018 edition, so I've used the same template. That one had a silence date of 01/01/2019. Thanks for triggering CI as well, the integration tests should start passing on 1.56 IIUC. |
Could you submit |
Sure, I've extracted the commit into #743 and removed it from this PR. |
8d1365d
to
645ba89
Compare
FWIW, I locally renamed beta to stable and ran the tests. I fixed up the failures and force pushed this branch. |
Thanks @shepmaster 🙏 |
since it's now available everywhere
645ba89
to
4007080
Compare
🚀 |
If GitHub ever lets the images be pushed… |
Now let’s do all the builds again for real |
👋
The 2021 edition will become stable when 1.56 is released, on the 21st of october, and this draft PR prepares the playground to using it as the default edition after its release.
Specifically, I've:
I'm opening this PR as draft:
♪ Edition! ♫