Skip to content

♪ EditiooOoOOnnN ! ♫ #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2021
Merged

♪ EditiooOoOOnnN ! ♫ #739

merged 4 commits into from
Oct 21, 2021

Conversation

lqd
Copy link
Member

@lqd lqd commented Sep 20, 2021

👋

The 2021 edition will become stable when 1.56 is released, on the 21st of october, and this draft PR prepares the playground to using it as the default edition after its release.

Specifically, I've:

  • Set 2021 as the default in the UI.
  • Removed the aside when setting the 2021 edition, as it will be available everywhere then.

I'm opening this PR as draft:

  • I couldn't really test the server side, and would like CI to run tests for me.
  • I wanted to ask for advice from Jake, in case I've forgotten other important steps and so on.
  • this PR should probably only be merged in a month when 1.56 is released.

♪ Edition! ♫

@shepmaster shepmaster added the CI: approved Allowed access to CI secrets label Sep 20, 2021
@shepmaster
Copy link
Member

One thing I think we should also add is a notification popup to let people know that 2021 is live and the default.

We should:

  1. Remove the old notification
  2. Add a notification for 2021

I don't have a great idea for the notification text or silence date, though.

@lqd
Copy link
Member Author

lqd commented Sep 20, 2021

Yes, indeed, good point about the notification. You had added one last time, for the 2018 edition, so I've used the same template. That one had a silence date of 01/01/2019.

Thanks for triggering CI as well, the integration tests should start passing on 1.56 IIUC.

@shepmaster
Copy link
Member

Could you submit remove special case for cargo "edition2021" feature as a separate PR? That should be able to be merged before the next Rust release.

@lqd
Copy link
Member Author

lqd commented Sep 21, 2021

Sure, I've extracted the commit into #743 and removed it from this PR.

@shepmaster
Copy link
Member

FWIW, I locally renamed beta to stable and ran the tests. I fixed up the failures and force pushed this branch.

@lqd
Copy link
Member Author

lqd commented Sep 29, 2021

Thanks @shepmaster 🙏

@shepmaster shepmaster added CI: approved Allowed access to CI secrets and removed CI: approved Allowed access to CI secrets labels Oct 21, 2021
@shepmaster shepmaster marked this pull request as ready for review October 21, 2021 15:18
@shepmaster shepmaster added CI: approved Allowed access to CI secrets and removed CI: approved Allowed access to CI secrets labels Oct 21, 2021
@lqd
Copy link
Member Author

lqd commented Oct 21, 2021

🚀

@shepmaster
Copy link
Member

If GitHub ever lets the images be pushed…

@shepmaster shepmaster merged commit 4f88ddf into rust-lang:master Oct 21, 2021
@shepmaster
Copy link
Member

Now let’s do all the builds again for real

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: approved Allowed access to CI secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants