Use 'setfiletype' to avoid load 'ftplugin/rust.vim' twice #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…call cargoquickfixCmdPre
fix syntax issue
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I am startled to see I don’t think I’ve ever seen |
Use the definitely the idiomatic spelling `setf`
It's done. |
alok
added a commit
to alok/rust.vim
that referenced
this pull request
Feb 5, 2019
* remotes/original/master: (423 commits) Use 'setfiletype' to avoid load 'ftplugin/rust.vim' twice (rust-lang#301) avoid setting `isfname` allow 'pub use' Set `include` and improve `includeexpr` Revert "BufWritePre should be <buffer>" Recognize edition2015 and edition2018 doc test specifiers Revert "RustTest: specify module name to run exact one test case" RustTest: specify module name to run exact one test case RustTest: use :terminal for running tests ftplugin/rust.vim: Better to narrow augroup scope rustfmt: remove incorrect version check rustfmt: simplify regex tests Improve 'async' contextual keyword highlighting (rust-lang#290) RustFmt: fix non-existant temp file Add new keywords (rust-lang#282) Add SyntasticInfo if exists to the output of RustInfo Check that Syntastic is new enough Update rust.txt Add `cargo#guessrun` function & `Cgrun` command Fix RunRustfmt() for Vim 7.x ...
This was referenced Apr 28, 2019
da-x
pushed a commit
that referenced
this pull request
May 19, 2019
- `:set filetype` forces a filetype. - `:setfiletype` only sets a filetype if it didn't already happen earlier due to the same event. Current versions of Vim and Neovim have a `$VIMRUNTIME/filetype.vim` that sets the `rust` filetype for all files with an `.rs` extension. This plugin did that with `set filetype=rust` as well. But now, with the filetype getting set twice, `ftplugin/rust/*` was sourced twice as well. This got fixed in #301 by changing `set filetype=rust` to `setfiletype rust`. But that fix introduced a regression for all older Vim versions. There is still a lot of Vim 7.4 around and Debian stable still provides Nvim 0.1.7, both being very old versions. The `$VIMRUNTIME/filetype.vim` of these old versions set the filetype to `hercules` for all `.rs` files via `setfiletype hercules`. Now, usually (it also depends on how plugins gets sourced) `filetype.vim` gets sourced _before_ any `ftdetect/*` files from plugins. And since autocmds are processed in order, Vim would first do `setfiletype hercules` and so any subsequent `setfiletype rust` fails. The obvious solution: Force the `rust` filetype for all `.rs` extensions unless the filetype is already set to `rust`. So, we have the filetype setting working again for older versions and also avoid setting the filetype twice. Fixes #306 Fixes #318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
au BufNewFile,BufRead *.rs setf rustin $VIMRUNTIME/filetype.vim had set the rust filetye,autocmd BufRead,BufNewFile *.rs set filetype=rustwill overrule it.This cause ftplugin/rust.vim will be loaded twice when the first is not loaded yet.