Skip to content

fail_bounds_check in unstable.rs should return ! #10023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Oct 23, 2013 · 1 comment · Fixed by #10042
Closed

fail_bounds_check in unstable.rs should return ! #10023

alexcrichton opened this issue Oct 23, 2013 · 1 comment · Fixed by #10042
Labels
A-codegen Area: Code generation E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@alexcrichton
Copy link
Member

This tells LLVM that the function returns, and will hopefully help codegen to place the failing bounds check function calls at the end of the codegen'd function instead of inline with the rest of the code.

It would also be great to have a before/after analysis of some bounds checks to see if this improves codegen at all.
@thestinger
Copy link
Contributor

I also have a branch adding support for a #[cold] attribute but I haven't actually investigated whether it helps yet... :)

@thestinger thestinger mentioned this issue Oct 24, 2013
Merged
bors added a commit that referenced this issue Oct 24, 2013
@bors
auto merge of #10042 : thestinger/rust/fail, r=sanxiyn
7075eb3 
Closes #10023
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 17, 2022
@bors
Auto merge of rust-lang#10023 - Jarcho:issue_10017, r=xFrednet
4129054 
Fix `zero_ptr` suggestion for `no_std` crates

fixes rust-lang#10017

---

changelog: Sugg: [`zero_ptr`]: Now suggests `core::` paths for `no_std` crates
[rust-lang#10023](rust-lang/rust-clippy#10023)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mark some functions as returning !
2 participants
@alexcrichton @thestinger