Skip to content

Associated functions on reexported private types cause linker errors #10051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimonSapin opened this issue Oct 24, 2013 · 2 comments
Closed

Comments

@SimonSapin
Copy link
Contributor

This is the same issue as #9790, but with associated functions (aka "static methods".)

Test case:

lib.rs:

pub use internal::S;
mod internal {
    pub struct S;
    impl S {
        pub fn test() {}
    }
}

main.rs:

extern mod lib;
fn main() {
    lib::S::test()
}

CC: @alexcrichton

@metajack
Copy link
Contributor

nominating

@alexcrichton
Copy link
Member

This appears to have been fixed in a25bbcc (and I remember adding tests for it). I talked to @SimonSapin on IRC, and it sounds like a rust upgrade is in order.

Sorry about this! Closing for now though.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 12, 2023
…exendoo

Fix FN in `needless_return`

Fixes rust-lang#10051

changelog: Enhancement: [`needless_return`]: Now detects more cases for returns of owned values
[rust-lang#10110](rust-lang/rust-clippy#10110)
<!-- changelog_checked -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants